Fix background jobs that previously failed and were never completed properly#3113
Draft
Fix background jobs that previously failed and were never completed properly#3113
Conversation
tw4l
force-pushed
the
issue-3067-rerun-bg-jobs-not-finished
branch
from
6277866 to
0bf8c12
Compare
This was referenced Mar 25, 2026
tw4l
force-pushed
the
issue-3067-rerun-bg-jobs-not-finished
branch
from
0bf8c12 to
acbddbf
Compare
tw4l
commented
Mar 25, 2026
|
|
||
| crawls_match_query = { | ||
| "oid": {"$in": orgs_with_replicas}, | ||
| "files": {"$elemMatch": {"replicas": {"$in": [None, []]}}}, |
Member
Author
There was a problem hiding this comment.
We may want to instead check that the length of the replica array isn't the same length as the number of configured replica locations. It's possible a file would be replicated to one location but not to another.
tw4l
commented
Mar 25, 2026
|
|
||
| profiles_match_query = { | ||
| "oid": {"$in": orgs_with_replicas}, | ||
| "resource.replicas": {"$in": [None, []]}, |
Member
Author
There was a problem hiding this comment.
We may want to instead check that the length of the replica array isn't the same length as the number of configured replica locations. It's possible a file would be replicated to one location but not to another.
tw4l
force-pushed
the
issue-3067-rerun-bg-jobs-not-finished
branch
from
acbddbf to
e5823e7
Compare
Some background jobs previously failed and did not have success or finished fields set due to bugs. The first migration targets these and ensures that their finished and success values are set in the database as expected. The second migration looks for all unreplicated crawl and profile files and replicates them. This is preferably to simply retrying older failed replication background jobs, as it is possible that the objects they correlate have been deleted or changed since and so those old jobs are no longer applicable.
tw4l
force-pushed
the
issue-3067-rerun-bg-jobs-not-finished
branch
from
e5823e7 to
a95d2bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3067
This PR includes two migrations:
finishedorsuccessset properly in the databaseWork in progress. In particular, we should make sure that we check for the expected number of replicas for each file rather than just whether they've been replicated at all.