fix: Deny reader creation for partitioned topics#409
Merged
BewareMyPower merged 1 commit intostreamnative:masterfrom Apr 11, 2026
Merged
Conversation
3a315be to
28d4872
Compare
BewareMyPower
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now during reader creation it validates and deny's multi topics via
pulsar-rs/src/consumer/builder.rs
Line 334 in 86fda88
but this catch fails to account for partitioned topics which returns multiple
joined_topics. This creates unpredictable behavior atpulsar-rs/src/consumer/builder.rs
Line 340 in 86fda88
This change changes the validation of topic len on
joined_topics.len()instead ofself.topicsto prevent unpredictable behavior.If we want to support partitioned topics in
pulsar-rsI can draft up a separate PR that internally changes theReaderto hold aInnerConsumerto account for partitioned topics