Skip to content

fix: update settings fallback html styling [IDE-1926]#465

Merged
ShawkyZ merged 1 commit intomainfrom
fix/IDE-1926_update-settings-fallback-html-styling
Apr 13, 2026
Merged

fix: update settings fallback html styling [IDE-1926]#465
ShawkyZ merged 1 commit intomainfrom
fix/IDE-1926_update-settings-fallback-html-styling

Conversation

@andrewrobinsonhodges-snyk
Copy link
Copy Markdown
Contributor

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Apr 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Behavioral Change 🟠 [major]

In the collectData function, the cliBaseDownloadURL field now falls back to its placeholder value (https://downloads.snyk.io) if the user leaves the input field empty. Previously, an empty input would result in an empty string being saved (as implied by HtmlResourceLoader.cs populating {{CLI_BASE_DOWNLOAD_URL}} with options.CliBaseDownloadURL ?? ""). This changes the behavior: if a user clears the field, they might intend to save an empty string, but the code will persist the default download URL. This divergence from other settings UI (SnykCliOptionsUserControl.cs) where CliBaseDownloadURL can be genuinely empty could lead to unexpected behavior if an empty string is expected in certain scenarios.

cliBaseDownloadURL: get('cliBaseDownloadURL').value || get('cliBaseDownloadURL').placeholder,
📚 Repository Context Analyzed

This review considered 24 relevant code sections from 15 files (average relevance: 0.69)

@ShawkyZ ShawkyZ merged commit 6ac3e28 into main Apr 13, 2026
14 checks passed
@ShawkyZ ShawkyZ deleted the fix/IDE-1926_update-settings-fallback-html-styling branch April 13, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants