You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the collectData function, the cliBaseDownloadURL field now falls back to its placeholder value (https://downloads.snyk.io) if the user leaves the input field empty. Previously, an empty input would result in an empty string being saved (as implied by HtmlResourceLoader.cs populating {{CLI_BASE_DOWNLOAD_URL}} with options.CliBaseDownloadURL ?? ""). This changes the behavior: if a user clears the field, they might intend to save an empty string, but the code will persist the default download URL. This divergence from other settings UI (SnykCliOptionsUserControl.cs) where CliBaseDownloadURL can be genuinely empty could lead to unexpected behavior if an empty string is expected in certain scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!