Skip to content

feat: settings HTML tabs#1185

Open
rrama wants to merge 35 commits intorefactor/IDE-1786_folder-config-refactoringfrom
feat/IDE-1762_ldx-sync-config-html-with-tabs
Open

feat: settings HTML tabs#1185
rrama wants to merge 35 commits intorefactor/IDE-1786_folder-config-refactoringfrom
feat/IDE-1762_ldx-sync-config-html-with-tabs

Conversation

@rrama
Copy link
Copy Markdown
Contributor

@rrama rrama commented Mar 25, 2026

Description

Settings laid out in tabs. AI generated with some guidance, so probably removed something we cared about..

Checklist

  • Tests added and all succeed
  • N/A
  • Regenerated mocks, etc. (make generate)
  • N/A (We should make the example page be generated though)
  • Linted (make lint-fix)
  • README.md updated, if user-facing
  • N/A
  • License file updated, if new 3rd-party dependency is introduced
  • N/A

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 25, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@@ -0,0 +1,122 @@
/*
* © 2022-2026 Snyk Limited
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dammit AI, why put 2022 here...

@rrama rrama changed the title feat: tabs feat: settings HTML tabs Mar 25, 2026
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from 8dc869e to 2db8f5c Compare March 25, 2026 12:47
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from 2db8f5c to 3a2e988 Compare March 25, 2026 13:47
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from 3a2e988 to f25bd53 Compare March 25, 2026 14:15
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from f25bd53 to 87eb172 Compare March 25, 2026 17:05
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from 87eb172 to d969350 Compare March 25, 2026 18:36
@rrama rrama force-pushed the feat/IDE-1762_ldx-sync-config-html-with-tabs branch from d969350 to 2ad9bc3 Compare March 25, 2026 20:20
@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Broken Selector for Reset Badges 🟠 [major]

The function updateSourceBadgesForReset now attempts to find a container with ID folder- + index + -advanced. However, looking at the generated HTML in scripts/config-dialog/config_output_single_solution.html and the tab implementation, folder settings panes are actually assigned IDs like folder-pane- + index. This mismatch causes the selector to fail, meaning users will not see the "Will Reset" visual feedback when clicking the reset button for folder overrides.

var container = dom.get("folder-" + folderIndex + "-advanced");
Inconsistent Folder Naming 🟡 [minor]

The loop in GetConfigHtml matches folders by comparing f.Path() == fc.FolderPath. If the workspace provides relative paths or different URI schemes than what is stored in StoredFolderConfigs, the matching will fail and labels will fall back to filepath.Base. Since the logic elsewhere in the system (e.g. UpdateSettings in configuration.go) uses types.PathKey for map keys, applying normalization here would ensure consistent folder labels in complex workspaces.

if f.Path() == fc.FolderPath {
📚 Repository Context Analyzed

This review considered 76 relevant code sections from 12 files (average relevance: 0.96)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants