-
Notifications
You must be signed in to change notification settings - Fork 15
test: unified converter tests #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rrama
wants to merge
19
commits into
main
Choose a base branch
from
test/unified-converter-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bb5d257
test: unified converter tests
rrama 92cf113
Merge branch 'main' into test/unified-converter-test
rrama bff0f14
test: update function call signature
rrama a1e619c
test: make Test_buildUpgradePath make more sense
rrama e39eff1
test: refactor `Test_buildRemediationAdvice` order
rrama c93b021
test: improve `Test_buildRemediationAdvice`
rrama 6c9d6d0
test: improve `Test_extractDependencyPath`
rrama 5b6ab00
test: improve `Test_buildMessage`
rrama ae7a98d
test: improve `Test_getIntroducingFinding`
rrama 5eaee03
test: improve up to `Test_extractUpgradePackage`
rrama df06f6d
test: vuln as direct and transative dependency
rrama d459d27
test: pull out setup helper for processIssue tests
rrama 6ef32e1
test: combine code lenses and actions test
rrama 39ab67e
test: pull out common graceful degradation asserts
rrama 489f126
test: combine both no fix available tests
rrama fe2153e
test: move Test_processIssue_NoFixAvailable up
rrama ae03a59
test: use table for processIssue golden path tests
rrama eec0323
test: lint
rrama 3d6c505
Merge branch 'main' into test/unified-converter-test
rrama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from
len(dependencyPath) == 0tolen(dependencyPath) < 2is a critical improvement. AccessingdependencyPath[1]when the slice has fewer than two elements would lead to a runtime panic. This fix correctly handles cases where the dependency path is empty or contains only a single element, preventing potential crashes.