1 line fix + benchmark: stop resetting class cache for each document#78
Open
Philosobyte wants to merge 2 commits intosimdjson:mainfrom
Open
1 line fix + benchmark: stop resetting class cache for each document#78Philosobyte wants to merge 2 commits intosimdjson:mainfrom
Philosobyte wants to merge 2 commits intosimdjson:mainfrom
Conversation
Author
|
@piotrrzysko I would appreciate if you could look at this 1 line fix (plus benchmark). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time we parse a document, we enter method
SchemaBasedJsonIterator.walkDocument. Every time we enter said method, we callclassResolver.reset();. This clears the class cache and defeats its purpose.I benchmarked by reading twitter.json into memory, splitting it into 100 individual messages (around ~6kB each), and having each iteration read the 100 messages individually.
We are far slower than Jackson:
I removed
classResolver.reset()and benchmarked again:We are now faster than Jackson.
Any reason this
classResolver.reset()call needs to exist?Here is my command so you can reproduce my results:
I also needed to update version of
jsoniterScalaVersion, or else I would get build errors.