Draft
Conversation
583a6f2 to
1af673c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up the server capability and a handler for completion requests.
I've run into an issue with how strict the current parser is:
https://github.com/sass/dart-sass-language-server/pull/34/files#diff-dfd87bf70431e0c34c7d859b41e81359474d0cff8488684c8796738aed0c3e72R87-R120
It makes perfect sense for a compiler to be this strict, but (especially for this feature) the language server needs the parser to run in a mode where it does its best to recover from these errors and returns the
Stylesheetin whatever state it currently is, errors and all.