Housekeeping updates and source code formatting files#57
Merged
evan-goode merged 3 commits intorpm-software-management:mainfrom Oct 29, 2025
Merged
Housekeeping updates and source code formatting files#57evan-goode merged 3 commits intorpm-software-management:mainfrom
evan-goode merged 3 commits intorpm-software-management:mainfrom
Conversation
More housekeeping in the project. This just keeps the git log output looking nice. Signed-off-by: Dave Cantrell <dcantrell@redhat.com>
Bring in clang-format and clang-tidy configuration files from dnf5 and put driver scripts in tools/. Go ahead and adopt the dnf5 coding style for this project. Resolves: SWM-3064 Signed-off-by: Dave Cantrell <dcantrell@redhat.com>
evan-goode
requested changes
Oct 27, 2025
Member
evan-goode
left a comment
evan-goode
left a comment
There was a problem hiding this comment.
Thanks. I never noticed those clang-tidy-changed, clang-format scripts, I always used pre-commit. Could we also bring over (the relevant portions of) .pre-commit-config.yaml from dnf5?
Based off the one from dnf5, stripped of irrelevant parts. Signed-off-by: Dave Cantrell <dcantrell@redhat.com>
Collaborator
Author
|
I use pre-commit too, but I like having the manual driver scripts as well. Added .pre-commit-config.yaml too. |
m-blaha
approved these changes
Oct 29, 2025
Member
m-blaha
left a comment
m-blaha
left a comment
There was a problem hiding this comment.
thanks for including also the pre-commit configuration!
evan-goode
approved these changes
Oct 29, 2025
Member
evan-goode
left a comment
evan-goode
left a comment
There was a problem hiding this comment.
Ah, yes. My requested changes. The changes that were requested by me. Evan's requested changes.
evan-goode
merged commit 5ea5353
into
rpm-software-management:main
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring over source code formatting configuration from dnf5 and add driver scripts to tools/. Update .mailmap as well.
Will make a separate commit to get the coding format updated across all of the source.