feat(sampler-composite): rename createComposableTraceIDRatioBasedSampler to createComposableProbabilitySampler#6564
Open
ravitheja4531-cell wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
…ler to createComposableProbabilitySampler Renames the function and class to align with the consistent probability sampling specification. The old `traceidratio` source and test files are replaced with `probability` equivalents. Closes open-telemetry#6540 Signed-off-by: Ravi Theja <ravitheja4531@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6564 +/- ##
==========================================
+ Coverage 95.74% 95.75% +0.01%
==========================================
Files 371 375 +4
Lines 12514 12725 +211
Branches 2962 3013 +51
==========================================
+ Hits 11981 12185 +204
- Misses 533 540 +7
🚀 New features to boost your workflow:
|
maryliag
reviewed
Apr 9, 2026
Contributor
|
Hey @ravitheja4531-cell I just noticed this is your first contribution in this repo! Welcome and thank you for contributing! 😄 There is just one small suggestion I made that you can "commit suggestion" and we should be able to approve/merge after that! |
Co-authored-by: Marylia Gutierrez <maryliag@gmail.com>
Author
|
@maryliag Thanks for the guidance .Really appreciate that . Commited the changes as suggested. |
4 tasks
pichlermarc
reviewed
Apr 10, 2026
Member
pichlermarc
left a comment
There was a problem hiding this comment.
thank you for working on this 🙌
looks good overall, changelog entry should go into the breaking changes section though :)
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
maryliag
reviewed
Apr 13, 2026
maryliag
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createComposableTraceIDRatioBasedSampler→createComposableProbabilitySamplerin@opentelemetry/sampler-compositeper issue renamecreateComposableTraceIDRatioBasedSamplertocreateComposableProbabilitySampler#6540ComposableTraceIDRatioBasedSampler→ComposableProbabilitySamplersrc/traceidratio.tswithsrc/probability.tsandtest/traceidratio.test.tswithtest/probability.test.tsREADME.mdandexperimental/CHANGELOG.mdCloses #6540
Test plan
experimental/packages/sampler-compositeprobability.test.tscovers description strings and sampling ratios