Filter processes before eval libc#313
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Apr 15, 2026
Merged
Conversation
grcevski
reviewed
Apr 9, 2026
grcevski
approved these changes
Apr 9, 2026
Contributor
grcevski
left a comment
grcevski
left a comment
There was a problem hiding this comment.
LGTM! I think the timing increase is negligible and the code is a lot more readable and easier to understand now.
basti1302
approved these changes
Apr 15, 2026
Member
Author
Contributor
I think we agreed in the channel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #311.
Processes filtered by include/exclude configuration were still triggering libc detection, producing spurious "failed to identify libc" warnings in the injector's stderr output. This PR moves config file reading and allow/deny evaluation ahead of libc detection. To support this reordering, environment variable lookups during config reading are done by reading /proc/self/environ directly rather than via std.posix.getenv, which depends on libc. Filtered processes now exit before libc detection is ever attempted. An integration test verifies that filtered processes produce no injector stderr output.
Fixes #314