feat(code-action): add quickfix to remove empty inherit#787
Closed
feat(code-action): add quickfix to remove empty inherit#787
Conversation
Mark DK_EmptyInherit diagnostic as isPreferred in the code action handler so that editors surface the existing "remove `inherit` keyword" fix as a preferred quickfix. Closes part of #466.
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a quickfix code action that removes empty
inherit;statements from Nix code.{ inherit; }{ }Changes
nixd/lib/Controller/CodeAction.cpp: MarkDK_EmptyInheritasisPreferredin the code action handler, so the existing diagnostic fix surfaces as a preferred quickfix in LSP clients.Behavior
The
DK_EmptyInheritdiagnostic and its associated fix (removing both theinheritkeyword and its;semicolon) already exist inlibnixf. This PR wires it into the LSP code action response withisPreferred: true, matching the pattern used byDK_UnusedDefLet.Test Plan
nixd/tools/nixd/test/code-action/empty-inherit/empty-inherit.md— lit test verifying the quickfix removesinherit;and returns the expected edit range withisPreferred: true.Related