Skip to content

Add CLAUDE.md and decisions.md#428

Open
rido-min wants to merge 3 commits intonext/corefrom
next/core-claude-agents
Open

Add CLAUDE.md and decisions.md#428
rido-min wants to merge 3 commits intonext/corefrom
next/core-claude-agents

Conversation

@rido-min
Copy link
Copy Markdown
Member

This pull request introduces a comprehensive multi-agent workflow for the Microsoft Teams .NET SDK project. It adds detailed role descriptions, responsibilities, constraints, and output formats for each agent in the pipeline—PM Spec Writer, Architect, Implementer, Code Reviewer, and Tester. It also documents the overall pipeline process, agent routing rules, and the shared decision log protocol. These changes formalize and standardize the project's contribution and review process.

Agent definitions and responsibilities:

  • Added .claude/agents/pm-spec.md to define the PM Spec Agent's role in translating user requests into actionable specifications, including required spec structure and hand-off protocol.
  • Added .claude/agents/architect.md to define the Architect Agent's responsibilities for technical design, API surface planning, and architectural decision logging.
  • Added .claude/agents/implementer.md to specify how the Implementer Agent writes code based on designs, including coding conventions, build commands, and constraints.
  • Added .claude/agents/code-reviewer.md to describe the Code Reviewer Agent's review criteria, output format, and rules for feedback and decision logging.
  • Added .claude/agents/tester.md to outline the Tester Agent's approach to writing and running tests, naming conventions, and reporting.

Pipeline process and documentation:

  • Added CLAUDE.md to document the overall project structure, the multi-agent pipeline flow, agent routing rules, hand-off protocol, and the purpose of the shared decisions.md log.
  • Updated decisions.md to provide a standardized format for logging decisions and trade-offs by all agents, ensuring chronological and append-only entries.

@rido-min rido-min added the CORE label Apr 15, 2026
## Constraints

- Do NOT modify code directly. Provide specific, actionable feedback with file paths and line numbers.
- If changes are needed, hand back to the implementer with clear instructions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a line verifying feedback against convention in the file/repo. Is it leaving feedback that would create an inconsistency with an existing pattern? If so at the very least, it should be noted that the change would make the code inconsistent.

As an example, copilot leaving feedback that the new method isn't using the return types noted in the JSdoc, but every other method in the file similarly returns only res.data, not the specific return type.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good idea, do you want to update this PR? or can we merge it and review/improve later?

@rido-min rido-min marked this pull request as ready for review April 15, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants