Skip to content

Python: Improve test coverage#10681

Merged
moonbox3 merged 19 commits intomicrosoft:mainfrom
rracanicci:feature/improve-test-coverage
Mar 12, 2025
Merged

Python: Improve test coverage#10681
moonbox3 merged 19 commits intomicrosoft:mainfrom
rracanicci:feature/improve-test-coverage

Conversation

@rracanicci
Copy link
Copy Markdown
Contributor

@rracanicci rracanicci commented Feb 25, 2025

Motivation and Context

Adding more tests to improve overall coverage.

Description

  • adding tests for bedrock agent channel
  • adding tests for bedrock model provider utils
  • adding tests for mistral ai chat completion
  • tests for bing search
  • tests for google search

Contribution Checklist

@rracanicci rracanicci requested a review from a team as a code owner February 25, 2025 17:55
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 25, 2025
@github-actions github-actions bot changed the title Improve test coverage Python: Improve test coverage Feb 25, 2025
@markwallace-microsoft
Copy link
Copy Markdown
Contributor

markwallace-microsoft commented Feb 25, 2025 •
edited
Loading

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL19779219689% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
3290 5 💤 0 ❌ 0 🔥 1m 43s ⏱️

eavanvalkenburg
eavanvalkenburg reviewed Feb 25, 2025
View reviewed changes
Comment thread python/tests/unit/connectors/search/google/test_google_search.py Outdated
TaoChenOSU
TaoChenOSU reviewed Feb 25, 2025
View reviewed changes
Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
Comment thread python/tests/unit/connectors/ai/bedrock/services/test_bedrock_model_provider_utils.py Outdated
Comment thread python/tests/unit/connectors/ai/mistral_ai/services/test_mistralai_chat_completion.py Outdated
Comment thread python/tests/unit/connectors/ai/mistral_ai/services/test_mistralai_chat_completion.py Outdated
Comment thread python/tests/unit/connectors/ai/mistral_ai/services/test_mistralai_chat_completion.py Outdated
Comment thread python/tests/unit/connectors/search/bing/test_bing_search.py Outdated
moonbox3
moonbox3 reviewed Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @rracanicci.

Comment thread python/tests/unit/agents/bedrock_agent/test_bedrock_agent_channel.py Outdated
@rracanicci rracanicci requested a review from a team as a code owner March 5, 2025 16:00
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core documentation memory labels Mar 5, 2025
@github-actions github-actions bot changed the title Python: Improve test coverage .Net: Python: Improve test coverage Mar 5, 2025
@rracanicci rracanicci force-pushed the feature/improve-test-coverage branch from 50cd0c6 to 4fb3101 Compare March 5, 2025 16:03
@markwallace-microsoft markwallace-microsoft removed .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core documentation memory labels Mar 5, 2025
@rracanicci rracanicci changed the title .Net: Python: Improve test coverage Python: Improve test coverage Mar 5, 2025
@rracanicci rracanicci force-pushed the feature/improve-test-coverage branch 2 times, most recently from 19bb678 to a815b23 Compare March 7, 2025 10:28
@rracanicci rracanicci force-pushed the feature/improve-test-coverage branch from 4476f53 to 8f62a96 Compare March 7, 2025 12:00
@moonbox3 moonbox3 enabled auto-merge March 12, 2025 07:45
@moonbox3 moonbox3 added this pull request to the merge queue Mar 12, 2025
Merged via the queue into microsoft:main with commit 63f140e Mar 12, 2025
28 checks passed
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
@rracanicci @moonbox3
Python: Improve test coverage (microsoft#10681)
4b6c230 
### Motivation and Context

Adding more tests to improve overall coverage.

### Description

- adding tests for bedrock agent channel
- adding tests for bedrock model provider utils
- adding tests for mistral ai chat completion
- tests for bing search
- tests for google search

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg left review comments

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees

No one assigned

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rracanicci @markwallace-microsoft @TaoChenOSU @eavanvalkenburg @moonbox3