Skip to content

Reorder search patterns for Pnpm component detection#1782

Merged
jpinz merged 1 commit intomainfrom
jupinzer/reorder-pnpm-search-patterns
Apr 15, 2026
Merged

Reorder search patterns for Pnpm component detection#1782
jpinz merged 1 commit intomainfrom
jupinzer/reorder-pnpm-search-patterns

Conversation

@jpinz
Copy link
Copy Markdown
Member

@jpinz jpinz commented Apr 15, 2026

As a part of the change in #1770, I updated SearchPatterns so that the earlier in the list, the higher the priority. And shrinkwrap.yaml is the old name for pnpm-lock.yaml so it shouldn't be first in the order anymore: https://github.com/orgs/pnpm/discussions/8595#discussioncomment-10813709

@jpinz jpinz requested a review from JamieMagee April 15, 2026 16:10
@jpinz jpinz self-assigned this Apr 15, 2026
@jpinz jpinz requested a review from a team as a code owner April 15, 2026 16:10
Copilot AI review requested due to automatic review settings April 15, 2026 16:10
@jpinz jpinz enabled auto-merge (squash) April 15, 2026 16:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reorders pnpm detector search patterns so the current lockfile name (pnpm-lock.yaml) is prioritized over the legacy (shrinkwrap.yaml), aligning with the priority semantics introduced in #1770.

Changes:

  • Reordered SearchPatterns in the pnpm detector factory to prefer pnpm-lock.yaml first.
Show a summary per file
File Description
src/Microsoft.ComponentDetection.Detectors/pnpm/PnpmComponentDetectorFactory.cs Updates pnpm lockfile search priority to prefer the modern filename.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@jpinz jpinz merged commit 52155a6 into main Apr 15, 2026
26 checks passed
@jpinz jpinz deleted the jupinzer/reorder-pnpm-search-patterns branch April 15, 2026 16:56
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.0%. Comparing base (445a1a2) to head (347b77c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1782   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants