Conversation
This patch is already included in 51.1.56 microsoft/cloud-hypervisor@69e16ca Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
14127e7 to
2b57379
Compare
d5eb2a8 to
c660781
Compare
|
todo: upload sources to mariner cache |
sprt
left a comment
There was a problem hiding this comment.
LGTM, just one nit about the version scheme.
|
|
||
| Name: kata-containers-preview | ||
| Version: 3.27.0~preview1 | ||
| Version: 3.27.0~preview2 |
There was a problem hiding this comment.
nit: IMO we should use the same version format as kata-containers since there's no reason to use a tilde (pre-release) for this package but not for the other one. The preview semantic is already captured in the package name.
There was a problem hiding this comment.
Are you saying to use 3.27.0.preview2 instead ? if so, I agree. It would also align with the GH tag https://github.com/microsoft/kata-containers/releases/tag/3.27.0.preview2 (GH doesn't support ~ in the tag) If @romoh agrees, I can follow up with a PR that switches to 3.27.0.preview2 (We'll have to be careful to make sure that 3.27.0~preview2 does not supersedes 3.27.0.preview2 )
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Upgrade cloud-hypervisor to v51.1.56. This requires a corresponding upgrade to kata-containers and kata-containers-preview
Change Log
Does this affect the toolchain?
NO
Test Methodology
kata-containers:
kata-containers-preview (tested through CI as kata-containers using this branch 3.0-dev...kata-ci/dom0/scheduled-upgrade-plus-kata-preview):