Skip to content

Localization change from build: 144417220#40175

Open
OneBlue wants to merge 1 commit intofeature/wsl-for-appsfrom
user/localization/144417220
Open

Localization change from build: 144417220#40175
OneBlue wants to merge 1 commit intofeature/wsl-for-appsfrom
user/localization/144417220

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented Apr 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 14, 2026 01:48
@OneBlue OneBlue requested a review from a team as a code owner April 14, 2026 01:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates multiple .resw localization files (generated from build 144417220) to sync string resources—primarily around WSLC CLI messaging/help text—and to add/remove a few message keys across locales.

Changes:

  • Adds new resource keys (e.g., MessageFailedToCreateDisk, several new WSLC session/container messages).
  • Updates many WSLC CLI strings (usage/help text, error messages, and some descriptions such as the --detach foreground/background behavior).
  • Removes MessageInstanceTerminated from the localized resource sets.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
localization/strings/zh-CN/Resources.resw Adds new keys and changes many WSLC-related strings; includes multiple English values in a non-English locale file.
localization/strings/ru-RU/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/pt-PT/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/pt-BR/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/nl-NL/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/it-IT/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/hu-HU/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/fr-FR/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/es-ES/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/en-GB/Resources.resw Adds new keys and updates WSLC strings; also changes some spellings to US variants.
localization/strings/de-DE/Resources.resw Same pattern of WSLC/key updates and English values introduced.
localization/strings/da-DK/Resources.resw Same pattern of WSLC/key updates and English values introduced.

Comment on lines 1916 to 1921
<data name="MessageWslcUsage" xml:space="preserve">
<value>wslc - WSL 容器 CLI
用法:
<value>wslc - WSL Container CLI
Usage:
wslc --help</value>
<comment>{Locked="--help"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several previously translated WSLC CLI strings have been replaced with English in the zh-CN resource file (e.g., the usage header). If the intent is to keep zh-CN localized, these should be translated; otherwise consider removing the zh-CN entries so en-US fallback is used consistently for WSLC CLI output.

Copilot uses AI. Check for mistakes.
</data>
<data name="WSLCCLI_UnrecognizedCommandError" xml:space="preserve">
<value>Unrecognised command: '{}'</value>
<value>Unrecognized command: '{}'</value>
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en-GB locale should generally use British spelling. This change switches "Unrecognised" to the US spelling "Unrecognized" (and similar changes elsewhere in this file), which is inconsistent with en-GB.

Suggested change
<value>Unrecognized command: '{}'</value>
<value>Unrecognised command: '{}'</value>

Copilot uses AI. Check for mistakes.
Comment on lines +859 to +862
<data name="MessageFailedToCreateDisk" xml:space="preserve">
<value>Failed to create disk '{}': {}</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These newly added locale entries are still in English (e.g., "Failed to create disk..."). For non-en locales, please either provide a translated value or omit the entry so the app falls back to the en-US baseline, instead of shipping an English override inside the zh-CN resource file.

Suggested change
<data name="MessageFailedToCreateDisk" xml:space="preserve">
<value>Failed to create disk '{}': {}</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants