Skip to content

Add test coverage for LoadImage/ImportImage on process exit/session terminate#40172

Open
yao-msft wants to merge 5 commits intofeature/wsl-for-appsfrom
user/yaosun/additionalloadimporttests
Open

Add test coverage for LoadImage/ImportImage on process exit/session terminate#40172
yao-msft wants to merge 5 commits intofeature/wsl-for-appsfrom
user/yaosun/additionalloadimporttests

Conversation

@yao-msft
Copy link
Copy Markdown

Summary of the Pull Request

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@yao-msft yao-msft requested a review from a team as a code owner April 13, 2026 22:43
Copilot AI review requested due to automatic review settings April 13, 2026 22:43
@yao-msft yao-msft changed the title Add test covergae for LoadImage/ImportImage on process exit/session terminate Add test coverage for LoadImage/ImportImage on process exit/session terminate Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Windows tests to verify LoadImage/ImportImage abort correctly when the data source is interrupted and/or the session is terminated, covering scenarios like caller process exit and session shutdown.

Changes:

  • Added LoadImage tests for abort behavior on broken pipe + session termination, and on session termination alone.
  • Added ImportImage tests for the same abort/termination scenarios.

@guanwenbin123

This comment was marked as off-topic.

Copilot AI review requested due to automatic review settings April 14, 2026 19:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings April 14, 2026 22:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants