Skip to content

Interface + base class for problem modulus#785

Open
GiovanniCanali wants to merge 9 commits intomathLab:0.3from
GiovanniCanali:problem_structure
Open

Interface + base class for problem modulus#785
GiovanniCanali wants to merge 9 commits intomathLab:0.3from
GiovanniCanali:problem_structure

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

@GiovanniCanali GiovanniCanali commented Apr 16, 2026

Description

This PR fixes #783

In this PR, the following updates have been introduced:

  • problem Module:
    • Introduced a unified interface along with a base class structure for problem definitions
    • Strengthened validation logic within AbstractProblem methods
    • Improved and expanded documentation for clarity and usability
    • Extended test coverage, including dedicated test files for each problem subclass (e.g., parametric, inverse, spatial, time-dependent)
  • problem/zoo Submodule:
    • Standardized naming of source and test files in accordance with PINA conventions
    • Resolved minor issues in DiffusionReactionProblem and AcousticWaveProblem
    • Added solution-based tests wherever analytical solutions are available

The core logic underpinning the entire problem module has remained unchanged from a user perspective.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this Apr 16, 2026
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-fix Label for PR that needs modification 0.3 Related to 0.3 release labels Apr 16, 2026
@GiovanniCanali GiovanniCanali requested a review from ndem0 April 16, 2026 09:40
@GiovanniCanali
Copy link
Copy Markdown
Collaborator Author

Tests that are currently failing are unrelated to the changes introduced in this PR and will be addressed prior to the release of version 0.3.

@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Apr 16, 2026
@GiovanniCanali GiovanniCanali marked this pull request as ready for review April 16, 2026 09:48
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners April 16, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.3 Related to 0.3 release enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants