Open
Conversation
rmweir
requested changes
Mar 21, 2025
Comment on lines
+48
to
+51
| *Downstream Client* | ||
|
|
||
| The vCluster Rancher operator runs in Rancher's local cluster and watches clusters.management.cattle.io. | ||
| When a cluster has not been seen by the handler before, it creates a client with a token, using the Rancher reverse proxy to talk to the downstream cluster. |
Collaborator
There was a problem hiding this comment.
This is still inaccurate. An important part of how the operator works is that on start up it creates a token for the users that the chart installs. In then uses that going forward instead of the service account. Most of the operator is leveraging a user that has the admin global role. I think this is important context for devs and maybe even users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.