More accurate 8-bit <=> 5-bit RGB color conversion#1827
Merged
Rangi42 merged 2 commits intogbdev:masterfrom Sep 8, 2025
Merged
More accurate 8-bit <=> 5-bit RGB color conversion#1827Rangi42 merged 2 commits intogbdev:masterfrom
Rangi42 merged 2 commits intogbdev:masterfrom
Conversation
954d833 to
bfb0de5
Compare
Contributor
Author
|
The four |
ISSOtm
requested changes
Sep 8, 2025
Rangi42
added a commit
to Rangi42/rgbds
that referenced
this pull request
Oct 24, 2025
This reverts commit 223b3d1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1823
The old formulas:
c >> 3(just truncates the low 3 bits, which biases by rounding down)(c << 3) | (c >> 2)(repeats the high 3 bits, which is not quite as accurate as true rounding)The new formulas:
(c * 31 + 127) / 255(c * 255 + 15) / 31(c * (2^B - 1) + (2^(A - 1) - 1)) / (2^A - 1)