Skip to content

Include search and filter for invoice page#234

Open
TChukwuleta wants to merge 2 commits intobtcpayserver:masterfrom
TChukwuleta:ft/search_and_filter
Open

Include search and filter for invoice page#234
TChukwuleta wants to merge 2 commits intobtcpayserver:masterfrom
TChukwuleta:ft/search_and_filter

Conversation

@TChukwuleta
Copy link
Copy Markdown
Collaborator

@TChukwuleta TChukwuleta commented Jul 2, 2025

Resolves #39

invoice_search

invoice_filter

This is open for review @Ghander @dstrukt @pavlenex

@dstrukt dstrukt self-requested a review July 2, 2025 17:41
@dstrukt
Copy link
Copy Markdown
Member

dstrukt commented Jul 2, 2025

Knocking through the issues - awesome work!

I'm still working through my previous review, had some issues with GH and my local build last night, but hoping to have the other one here shortly - added myself as a reviewer here as well.

Copy link
Copy Markdown
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tACK - this is great, awesome work!

Only have a few minor nits:

  • Let's push the option selection to 100% width of the container (vs like the right 70% as seen below) - it looks almost right, but i think the container mostly just needs to be pushed flush to the far left and 100% width like so:

  • The selection background-color should just be a shade or two darker than the background of the modal, not our green

Screen Shot 2025-07-03 at 12 19 07 AM Screen Shot 2025-07-03 at 12 06 25 AM Screen Shot 2025-07-03 at 12 06 28 AM

Otherwise, i think this is GTG from a design / functional review, and can move on to a code review!

@TChukwuleta
Copy link
Copy Markdown
Collaborator Author

Hey @dstrukt I have updated the correction

image

@TChukwuleta TChukwuleta requested a review from dstrukt July 3, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement basic search and filtering on Invoice view

2 participants