Skipping-refresh-for-already-invalidated-credential-ids#1680
Open
teg-atlassian wants to merge 1 commit intomainfrom
Open
Skipping-refresh-for-already-invalidated-credential-ids#1680teg-atlassian wants to merge 1 commit intomainfrom
teg-atlassian wants to merge 1 commit intomainfrom
Conversation
teg-atlassian
requested review from
BHulovatyi,
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
cindy-atl,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian and
sky-ocean-spirits
as code owners
teg-atlassian
changed the title
teg-atlassian
force-pushed
the
Skipping-refresh-for-already-invalidated-credential-ids
branch
from
325ee8b to
110a04f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Is This Change?
There are cases where we refresh tokens of credential ids which we have marked invalid. If a credential id is invalid, refreshing tokens wouldn't help. This pr prevents refreshing tokens of invalid credentialIds
How Has This Been Tested?
Basic checks:
npm run lintnpm run testnew testsAdvanced checks:
Recommendations:
Rovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.