bsp: ship Armbian distributor logo (svg + wordmark png variants)

[igorpecovnik]

Summary

`artifact-armbian-base-files.sh:169` writes `LOGO="armbian-logo"` into `/etc/os-release`, but no actual `armbian-logo` file ever lands on the rootfs. So GNOME Settings → About, KDE Info Center, and every other panel that reads `LOGO=` from os-release looks up `armbian-logo` in the icon search paths, finds nothing, and silently falls back to the upstream distro logo. Branding has been broken at the file-presence level for as long as that field has been there.

Fix

Ship three files via the BSP overlay tree, matching upstream Ubuntu's three-file layout in base-files:

file	path	size	role
logomark	`/usr/share/pixmaps/armbian-logo.svg`	30 KB	what `LOGO=armbian-logo` resolves to (icon-spec lookup picks SVG first)
wordmark light	`/usr/share/pixmaps/armbian-logo-text.png`	8 KB, 400×64	for apps that prefer the text-bearing icon on a light background
wordmark dark	`/usr/share/pixmaps/armbian-logo-text-dark.png`	8 KB, 400×64	same, dark background

Compare with upstream:
```
ubuntu-logo.svg (890 bytes)
ubuntu-logo-text.png (260×91, 5 KB)
ubuntu-logo-text-dark.png (256×89, 4.6 KB)
```

All three land on every Armbian image (CLI or desktop) via `armbian-bsp-cli`'s existing `rsync` of `packages/bsp/common/` (`armbian-bsp-cli-deb.sh:127`). No build-flow changes, no postinst hooks needed — they're picked up by the icon cache automatically as part of `/usr/share/pixmaps/`.

Follow-ups (separate PRs)

• Once armbian-base-files migration (Phase 0) lands — move logo ownership from `armbian-bsp-cli` to the repacked `base-files` package for symmetry with upstream
• Further SVG optimization: 30 KB → ~1 KB territory with more aggressive svgo passes; adequate as-is for the icon-cache use case

Test plan

• Build a fresh image and confirm all three files are present under `/usr/share/pixmaps/`
• On a desktop image: GNOME Settings → About displays the Armbian logo (not the Ubuntu/Debian fallback)
• On KDE: System Information / Info Center displays the same
• Boot/login screens that use the wordmark variant (depending on greeter) pick up `armbian-logo-text.png` / `-dark.png` instead of the upstream wordmark

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)

• packages/bsp/common/usr/share/pixmaps/armbian-logo-text-dark.png is excluded by !**/*.png
• packages/bsp/common/usr/share/pixmaps/armbian-logo-text.png is excluded by !**/*.png
• packages/bsp/common/usr/share/pixmaps/armbian-logo.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63567d04-9918-426d-9d76-3d08d1a0c0c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bsp-armbian-logo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}