Replace more `ACTOR`s from `genericactors.actor.h` by tclinkenbeard-oai · Pull Request #13004 · apple/foundationdb

tclinkenbeard-oai · 2026-04-15T23:20:35Z

This PR is part of a larger effort to migrate genericactors.actor.h from Flow to pure C++. Changes consist of:

Removing unused ACTORs
Extending the generic_coro namespace by porting several actors, to eventually replace ACTOR implementations
For several generic actors without performance-sensitive call-sites, convert directly to standard coroutines

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2026-04-15T23:26:33Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: fed94b6
Duration 0:05:47
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-15T23:26:35Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: fed94b6
Duration 0:05:51
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-15T23:45:49Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: fed94b6
Duration 0:25:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:05:05Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: d1ec99d
Duration 0:20:08
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:05:31Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: fed94b6
Duration 0:44:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:05:32Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: d1ec99d
Duration 0:20:35
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-16T00:06:46Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: d1ec99d
Duration 0:21:50
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:19:09Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: d1ec99d
Duration 0:34:11
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:21:41Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: fed94b6
Duration 1:00:51
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:27:26Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: d1ec99d
Duration 0:42:30
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T00:27:49Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: d1ec99d
Duration 0:42:01
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

gxglass · 2026-04-16T05:01:08Z

@@ -65,8 +65,7 @@ struct CycleWorkload : TestWorkload, Arena {
 			return Void();
 		}
 		// TODO(gglass): possible cleanup here.  Leftover tenant stuff.


I think this line can be deleted while you're here

gxglass · 2026-04-16T05:28:36Z

+template <class T>
+Future<Void> uncancellable(Uncancellable, Future<T> what, Promise<T> result) {
+	ErrorOr<T> res = co_await coro::errorOr(what);
+	if (result.present()) {


I think I agree with this:

foundationdb-ci · 2026-04-16T06:14:09Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 5e16558
Duration 0:18:31
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-16T06:15:20Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 5e16558
Duration 0:19:45
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T06:22:53Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 5e16558
Duration 0:27:17
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T06:29:57Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 5e16558
Duration 0:34:21
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T06:40:22Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 5e16558
Duration 0:44:46
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T06:42:35Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 5e16558
Duration 0:46:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T07:00:50Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 5e16558
Duration 1:05:12
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:04:51Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 609d27b
Duration 0:27:24
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-16T08:05:02Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 609d27b
Duration 0:27:36
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:07:14Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 609d27b
Duration 0:29:48
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:19:54Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 609d27b
Duration 0:42:30
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:24:22Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 609d27b
Duration 0:46:55
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:29:20Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: daeb389
Duration 0:18:19
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:29:40Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: daeb389
Duration 0:18:37
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:34:12Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: daeb389
Duration 0:23:08
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:34:19Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: daeb389
Duration 0:23:16
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:35:24Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: daeb389
Duration 0:24:20
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-16T08:36:28Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: daeb389
Duration 0:25:25
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T08:43:20Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 609d27b
Duration 1:05:53
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T21:32:07Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: becb7c6
Duration 0:27:47
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-04-16T21:32:49Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: becb7c6
Duration 0:28:34
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T21:58:07Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: becb7c6
Duration 0:53:55
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-04-16T22:09:15Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: becb7c6
Duration 1:05:00
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Expand generic_coro namespace

fed94b6

Add missing co_await statement

d1ec99d

gxglass reviewed Apr 16, 2026

View reviewed changes

Fix uncancellable bug

5e16558

tclinkenbeard-oai added 2 commits April 16, 2026 00:29

Remove outdated comment

c29dd73

Workaround gcc bug

609d27b

Workaround gcc bug in more places

daeb389

Move printRedwoodStats definition

becb7c6

tclinkenbeard-oai requested a review from gxglass April 16, 2026 21:10

Conversation

tclinkenbeard-oai commented Apr 15, 2026

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Apr 15, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 15, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 15, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

gxglass Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

gxglass Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Apr 16, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!