This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Preserve entity mapping on certificate renewal#177
Open
WashingtonKK wants to merge 2 commits intoabsmach:mainfrom
Open
NOISSUE - Preserve entity mapping on certificate renewal#177WashingtonKK wants to merge 2 commits intoabsmach:mainfrom
WashingtonKK wants to merge 2 commits intoabsmach:mainfrom
Conversation
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
suggested changes
Sep 30, 2025
|
|
||
| entityID, err := s.repo.GetEntityIDBySerial(ctx, serialNumber) | ||
| if err == nil { | ||
| if err := s.repo.SaveCertEntityMapping(ctx, newCert.SerialNumber, entityID); err != nil { |
Contributor
There was a problem hiding this comment.
renew should have the same serial number
Contributor
|
repurpose to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes