fix: show notification when /qs is submitted without selecting a preview item#80
Open
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
Open
fix: show notification when /qs is submitted without selecting a preview item#80sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Collaborator
|
@sezallagwal resolve conflicts please |
…iew item The executor() method was empty, so typing /qs <text> and pressing Enter without selecting from the preview dropdown silently did nothing. Now it sends a notification guiding the user to select a reply from the preview list. Added the Qs_Select_Preview_Hint translation key to all five locales (en, de, pl, pt, ru).
sezallagwal
force-pushed
the
fix/qs-executor-silent-failure
branch
from
c2f879e to
2a88e92
Compare
Contributor
Author
|
@iam-vipin done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you type
/qs sometextand press Enter without selecting a reply from the preview dropdown, absolutely nothing happens no message, no error, no feedback. The user is left wondering if the command is broken.This is because the
executor()method inQsCommand.tsis completely empty (just a placeholder comment). Theexecutorruns when the user submits the slash command directly, whileexecutePreviewItemonly runs when they click on a preview item. Since most users type and hit Enter by habit, they get a silent failure on their first try.Steps to reproduce
/quick create)/qs helloin any channelFix
executor()method to send a helpful notification guiding the user to select from the preview list instead of pressing EnterQs_Select_Preview_Hinttranslation key to all 5 locales (en, de, pl, pt, ru)Demo