[FEAT] : Added dynamic initial values in create modal by not-meet · Pull Request #23 · RocketChat/Apps.QuickReplies

not-meet · 2024-11-22T05:30:14Z

Issue(s)

Closes #22

##This PR introduces a new feature that allows users to add the name and body of the new quick message from the rc rooms message box itself

Acceptance Criteria fulfillment

Add initial values to the create modal.
Update the readme file as per the same.

Proposed changes (including videos or screenshots)

User can now add the reply name and replybody from the rooms message box itself as
/quick create "reply name" reply body
to have the reply value in the modal

Demo

Screencast.from.2025-02-23.02-37-52.webm

here i have shown the demo of all three cases

case where user creates reply from the modal (normally)
case where a user uses the rooms input box to add the name and body
case where a user changes the value he putted in the modal from the input box

up for any changes and learning :)

CLAassistant · 2024-11-22T05:30:19Z

All committers have signed the CLA.

iam-vipin

There is alot of thing's that make no sense, try to make a PR that is clear and not bloated it, Ideally a PR should not have move then 200-300 line of code.

iam-vipin · 2024-11-22T06:15:39Z

-	IModify,
-	IPersistence,
-	IRead,
+    IHttp,


remove these spaces

iam-vipin · 2024-11-22T06:15:47Z

-	public persis: IPersistence;
-	public triggerId?: string;
-	public threadId?: string;
+    public app: QuickRepliesApp;


iam-vipin · 2024-11-22T06:16:46Z

+                const subCommand = this.params[0].toLowerCase();
+
+                if (
+                    subCommand === CommandParam.CREATE ||


why are we creating team in all the command ? explain me this

iam-vipin · 2024-11-22T06:17:00Z

+                await this.handleSingleParam(handler);
+                break;
+            }
+            default: {


this should not be in default

iam-vipin · 2024-11-22T06:17:28Z

+            }
+        }
+    }
+    private async handleQuickCreate(handler: Handler, args: string[]): Promise<void> {


we already handled default cases

iam-vipin · 2024-11-22T06:18:30Z

+    );
+
+    if (args.length < 3) {
+        await sendUsageMessage(modify, room, sender);


what is this ?

iam-vipin · 2024-11-22T06:18:45Z

-			return;
-		}
-	}
+    public app: QuickRepliesApp;


too much bloated code remove all these spaces

iam-vipin · 2024-11-22T06:19:12Z

+    room: IRoom,
+    user: IUser,
+): Promise<void> {
+    const text = '/quick-create <replyName> "<replyBody>"';


why we have this code ?

iam-vipin

Make requested changes

not-meet · 2024-11-22T12:34:38Z

Hi @VipinDevelops so i reflected the changes you asked for and made them as per the requirements

Note
the reason of adding the handlequickcreate function in the default is because of the number of arguments and the authentication of the keyword used as the switch case works on the parameters of length so as there can be a high chances of having uncertainty of inputs ive added quick create function in the default as it gets only called when there is a create keyword in the first index! :)

iam-vipin

There is still a lot of room for improvement basically you are repeating a lot of code and not following best practice.

iam-vipin · 2024-11-23T15:27:38Z

 			}
 			default: {
-				await handler.sendDefault();
+				const subCommand = this.params[0].toLowerCase();


you don't have to put this in switch case you can handle this in global

no updates here ?

iam-vipin · 2024-11-23T15:28:25Z

 		}
 	}
+
+	private async handleQuickCreate(handler: Handler, args: string[]): Promise<void> {


why dont use the function we already have for creating new replies ?

iam-vipin · 2024-11-23T15:28:47Z

+		  return;
+		}
+
+		switch (args[0].toLowerCase()) {


why switch case in a function that is made to create a reply ?

iam-vipin · 2024-11-23T15:29:49Z

+			await handler.CreateQuickReply(args);
+			break;
+		  }
+		  default: {


this is the third place where you please .sendDefault() is there any other way to achieve check without repeating this

iam-vipin · 2024-11-23T15:30:09Z

 			return;
 		}
 	}
+	public async CreateQuickReply(args: string[]): Promise<void> {


we do have a method already for this

iam-vipin · 2024-11-23T15:33:29Z

Also, update the documentation accordingly.

…e best practice

not-meet · 2024-11-30T15:16:56Z

hey @VipinDevelops made changes as you asked..! now i believe the code looks much cleaner to be merged...
up if there are any other changes to be made : )

iam-vipin · 2024-12-16T18:17:50Z

Hey @not-meet Can you explain a little about changes you have made and use the code we have already for creating replies I have seen you writing some code again that already exist Either reuse the function we have or make something new that can be use in both old and new code.

not-meet · 2024-12-17T08:56:57Z

hey!! @VipinDevelops
so I've added conditional logic in the CreateModal to take the reply name and body from CLI arguments as the original modal uses the input from the input boxes in the modal.

I wrote new logic instead of modifying the existing modal to avoid conflicts. While I understand the concern about calling the handler in the default switch case instead of passing it globally, doing so avoids issues where the global call still triggers the switch case unintentionally.

not-meet · 2025-02-12T16:37:04Z

Hey! @VipinDevelops i have made the changes as you asked! now i believe the code is much cleaner.... also added an example in readme to help user to get the context of quick create cli command!

iam-vipin · 2024-12-16T18:13:10Z

 export class QuickRepliesApp extends App {
 	private elementBuilder: ElementBuilder;
 	private blockBuilder: BlockBuilder;
+	public params: Array<string>; 


what is this ?

iam-vipin · 2024-12-16T18:13:18Z

 			http,
 			persistence,
 			modify,
+			this.params,


iam-vipin · 2024-12-16T18:13:35Z

 			}
 			default: {
-				await handler.sendDefault();
+				const subCommand = this.params[0].toLowerCase();


no updates here ?

iam-vipin · 2024-12-16T18:13:51Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	args : string[];


iam-vipin · 2024-12-16T18:15:58Z

 	room: IRoom,
 	language: Language,
-): Promise<IUIKitSurfaceViewParam | Error> {
+	args: string[],


why add this logic again we can just use the arguments to pass in the existing function

iam-vipin · 2025-02-13T10:38:21Z

 				break;
 			}
-			default: {
+			default: {				


iam-vipin · 2025-02-13T10:38:26Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	args? : string[];


why optional ? it will always be there

iam-vipin · 2025-02-13T10:38:32Z

 			this.modify,
 			this.room,
 			this.language,
+			this.args ?? [],


iam-vipin · 2025-02-13T10:38:36Z

 			return;
 		}

+		if (!modal) {


iam-vipin · 2025-02-13T10:38:52Z

 	language: Language,
-): Promise<IUIKitSurfaceViewParam | Error> {
+	args: string[],
+): Promise<IUIKitSurfaceViewParam | Error | void> {


no change here

iam-vipin · 2025-02-21T05:36:35Z

Again fix PR name , please follow the standard for everything you do

iam-vipin

Alot of changes required

iam-vipin · 2025-02-21T05:37:37Z


-		const commandUtility = new CommandUtility(commandUtilityParams);
-		await commandUtility.resolveCommand();
+		await new CommandUtility(commandUtilityParams).resolveCommand();


iam-vipin · 2025-02-21T05:38:40Z

 			label: labelReplyBody,
 			optional: false,
 			multiline: true,
+			initialValue: args.length > 2 ? args.slice(2).join(' ') : undefined,


i dont think that's how you should do this

iam-vipin · 2025-02-21T05:38:47Z

 		super(info, logger, accessors);
 	}
+
+	public setCommandParams(userId: string, params: string[]) {


what is this ?

iam-vipin · 2025-02-21T05:38:57Z

 		persistence: IPersistence,
 		modify: IModify,
 	) {
+		const userId = context.getInteractionData().user.id;


again what is this ?

iam-vipin · 2025-02-21T05:39:08Z

 		modify: IModify,
 	) {
+		const userId = context.getInteractionData().user.id;
+		const storedParams = this.getCommandParams(userId);


why are you strong params makes no sense to me

iam-vipin · 2025-02-21T05:39:41Z

 		protected readonly http: IHttp,
 		protected readonly persistence: IPersistence,
 		protected readonly modify: IModify,
+		protected readonly params: ICommandUtilityParams['params'],


iam-vipin · 2025-02-21T05:39:45Z

 						view,
 						language,
 						triggerId,
+						this.params


iam-vipin · 2025-02-21T05:40:15Z

-		const name = nameStateValue ? nameStateValue.trim() : '';
-		const body = bodyStateValue ? bodyStateValue.trim() : '';
+
+		const argsName = params.length > 1 ? params[1] : undefined;


why undefined that should not be possible

iam-vipin · 2025-02-21T05:41:00Z

+
+		const argsName = params.length > 1 ? params[1] : undefined;
+		const argsBody = params.length > 2 ? params.slice(2).join(' ') : undefined;
+		const name = argsName ? argsName : nameStateValue ? nameStateValue.trim() : '';


this ternary operator is doing simple thing in much complex way

iam-vipin · 2025-02-21T05:41:05Z

 		this.triggerId = params.triggerId;
 		this.threadId = params.threadId;
 		this.language = params.language;
+		this.args = params.args;


not-meet · 2025-02-21T07:42:56Z

hi! sorry for the delay for now i have changed the pr name and in the recent commit was just trying this approach, I will
go through the reviews and make a final commit as soon as possible

iam-vipin

read how I named my intial PR and use similar name I won't allow any PR that is not following good naming and description practice.

iam-vipin · 2025-02-23T07:06:56Z

 -   **`/quick ai`**: Use AI to generate replies
 -   **`/quick help`**: Get help with Quick Reply
 -   **`/qs <reply name>`**: Quickly search and send a reply by name
+-   **`/quick create <name> <message>`**:  Create a quick reply directly from the input box with a name and message


put create command together , explain how double quotes works to name a reply

iam-vipin · 2025-02-23T07:07:14Z

 				break;
 			}
-			default: {
+			default: {	


iam-vipin · 2025-02-23T07:10:04Z

-			view.state?.[CreateModalEnum.REPLY_BODY_BLOCK_ID]?.[
-				CreateModalEnum.REPLY_BODY_ACTION_ID
-			];
+		const nameStateValue = view.state && Object.values(view.state)


this code is so bad adding find don't make sense to me here and again you are not using enums , please find why enum are good and how we are using in this case.

iam-vipin · 2025-02-23T07:10:33Z

 	}

 	public async CreateReply(): Promise<void> {
+		const cliName = this.args?.[1] || '';


could we give them better naems like initial name or something ? or can we just make one object that have both values

iam-vipin

you are close

iam-vipin · 2025-02-25T20:58:29Z

 -   **`/quick ai`**: Use AI to generate replies
 -   **`/quick help`**: Get help with Quick Reply
 -   **`/qs <reply name>`**: Quickly search and send a reply by name
+-   **`/quick create <name> <message>`**:  Create a quick reply directly from the input box with a name and message


double quotes ("") ? Explain double quote behavior here

iam-vipin · 2025-02-25T20:59:27Z

 			triggerId: this.triggerId,
 			threadId: this.threadId,
 			language,
+			args: this.params,


why not name it params only then ?

iam-vipin · 2025-02-25T20:59:39Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	args? : string[];


why optional ? it will always be there

iam-vipin · 2025-02-25T20:59:48Z

 	public triggerId?: string;
 	public threadId?: string;
 	public language: Language;
+	public args? : string[];


iam-vipin · 2025-02-25T21:01:03Z

 	}

 	public async CreateReply(): Promise<void> {
+		const initialReplyName = this.args?.[1] || '';


initial values are optional why OR here ? just don't pass it if its not there

iam-vipin · 2025-02-25T21:01:08Z

 		text: label,
 		element: plainTextInputElement,
 		optional,
+		blockId,


iam-vipin · 2025-02-25T21:01:25Z

 	modify: IModify,
 	room: IRoom,
 	language: Language,
+	initialReplyName: string,


we can make it a object but fine for now

iam-vipin

When you make requested changes also share about what you changed in comment or reply

iam-vipin · 2025-02-26T20:50:49Z

+
+#### Example:
+```sh
+/quick create "greeting" Hello! How have you been?


This is not what I ment

How double quotes make the multiple words a single text for body use

iam-vipin · 2025-02-26T20:51:14Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	params?: string[];


Why optinal?

not answered ?

again not answered?

not-meet · 2025-02-26T20:54:53Z

hey @VipinDevelops i've added the comments with detailed explanation of what changes i have made

not-meet · 2025-02-27T00:47:39Z

Ive made the required changes in the readme file

added the detailed explanation and examples how "quotes" work .

NOTE-i have also added comments in all the changes i have made with detailed reasoning's kindly go through them as well

iam-vipin

requested more changes
don't tag me before you reply to all the old messages

iam-vipin · 2025-02-27T06:12:36Z

+#### Creating Quick Replies from Message Box
+**`/quick create "<name>" <message>`**: Create a quick reply using the message box
+
+When you use this command:
+1. A modal window opens automatically
+2. The name and replybody field is prefilled with your specified values
+3. Simply review and click the Submit button to save your quick reply
+
+The command works as follows:
+- The name must be enclosed in quotes `"..."` if it contains multiple words
+- Everything after the name is treated as the message body
+- Without quotes, only the first word would be taken as the name
+
+#### Examples:
+```sh
+# Single word name (quotes optional)
+/quick create greeting Hello! How have you been?
+
+# Multi-word name (quotes required)
+/quick create "welcome message" Welcome to our channel! How can I help you?
+```
+
+Both examples will open a modal with the name and message already filled in. Just click Submit to save your quick reply, which can then be used with **`/qs <name>`**.
+


That is just to much for such simple thing

and can't we just do like

/quick create "you can use double quotes to write the name with spaces" you write everything else as a body ??

this just looks like AI-generated markdown to me

iam-vipin · 2025-02-27T06:12:49Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	params?: string[];


not answered ?

iam-vipin · 2025-02-27T06:12:57Z

 	public triggerId?: string;
 	public threadId?: string;
 	public language: Language;
+	public params?: string[];


not-meet · 2025-02-27T23:16:57Z

hey @VipinDevelops
i have made the requested changes in the readme

i have added examples as well

not-meet · 2025-02-27T23:21:45Z

I have also replied to the asked questions in the messages in the review section in each file still to ease it out

why i added params as optional?

so the reason to make this optional is because not all the handler implementations such as executeActionbutton or executeBlockAction, they dont need params to run thus i made this optional as it removes unnecesary addition of parameter

not-meet · 2025-02-27T23:24:35Z

@VipinDevelops i was thinking about making a new pr for the same as this pr now has too many conversation messages and commits thus makes it a bit more clutterd and not easy to get through all the messages and conversation

i am thinking if you allow me to make a new pr for this issue with the same commits and solution

iam-vipin · 2025-02-28T05:34:44Z

hey @VipinDevelops i have made the requested changes in the readme

i have added examples as well

Super bad example Can't understand anything make it simple and short

iam-vipin · 2025-02-28T05:35:15Z

I have also replied to the asked questions in the messages in the review section in each file still to ease it out

why i added params as optional?

so the reason to make this optional is because not all the handler implementations such as executeActionbutton or executeBlockAction, they dont need params to run thus i made this optional as it removes unnecesary addition of parameter

Just remove it if not needed why make it optional ?

iam-vipin · 2025-02-28T05:35:50Z

@VipinDevelops i was thinking about making a new pr for the same as this pr now has too many conversation messages and commits thus makes it a bit more clutterd and not easy to get through all the messages and conversation

i am thinking if you allow me to make a new pr for this issue with the same commits and solution

NO we won't make new PR's because of TOO MANY conversations

not-meet · 2025-02-28T15:47:33Z

I have also replied to the asked questions in the messages in the review section in each file still to ease it out

why i added params as optional?

so the reason to make this optional is because not all the handler implementations such as executeActionbutton or executeBlockAction, they dont need params to run thus i made this optional as it removes unnecesary addition of parameter

Just remove it if not needed why make it optional ?

See Handler function is implemented in three files executeBlockActionhandler , executeActionButtonHandler and commandUtilty where only the command utility needs params as the createReply uses params to get the initial values

here are all the places where the handler is used
Notice how only one handler needs params - thus i added params as optional as it can only be passed where it is necessary just like how thriggerID args works

not-meet · 2025-02-28T15:51:10Z

hey @VipinDevelops i have made the requested changes in the readme
i have added examples as well

Super bad example Can't understand anything make it simple and short

How about this i have changed the examples and made them quite more clear

iam-vipin

There are still a lot of changes needed for this.

We are just making it longer—try to fix it this time

iam-vipin · 2025-03-19T06:41:51Z

 -   **`/quick help`**: Get help with Quick Reply
 -   **`/qs <reply name>`**: Quickly search and send a reply by name
+-   **`/quick create <name> <message>`**:  Create a quick reply directly from the input box with a name and message
+


add SS man why you are not making requested changes before asking for review.

iam-vipin · 2025-03-19T06:42:45Z

+**`/quick create "<name>" <message>`**: "if your name has multiple words with space, use double quotes" and write everything else as a body!
+
+Example: `/quick create "schedule meeting" let's have a quick meet in an hour!`
+


This is not what I meant.

Can you please avoid writing a lot in the README to explain really simple things?

iam-vipin · 2025-03-19T06:43:11Z


 export type IHanderParams = Omit<ICommandUtilityParams, 'params'> & {
 	language: Language;
+	params?: string[];


again not answered?

iam-vipin · 2025-03-19T06:43:19Z

 	public triggerId?: string;
 	public threadId?: string;
 	public language: Language;
+	public params?: string[];


iam-vipin · 2025-03-19T06:43:23Z

 		text: label,
 		element: plainTextInputElement,
 		optional,
+		blockId,


iam-vipin · 2025-03-19T06:43:46Z

 	modify: IModify,
 	room: IRoom,
 	language: Language,
+	initialReplyName?: string,


i said already we can make a new type for this or interface

iam-vipin reviewed Nov 22, 2024

View reviewed changes

iam-vipin requested changes Nov 22, 2024

View reviewed changes

not-meet force-pushed the quickcreatereplies branch from 9612a78 to db79d2c Compare November 22, 2024 12:30

not-meet requested a review from iam-vipin November 22, 2024 12:35

iam-vipin reviewed Nov 23, 2024

View reviewed changes

made changes in the pr as per the comments removed unused code for th…

7d8d7b0

…e best practice

not-meet force-pushed the quickcreatereplies branch from db79d2c to 7d8d7b0 Compare November 30, 2024 15:04

not-meet added 2 commits November 30, 2024 20:41

removed linting commits

1a58780

removed comments

cca74eb

not-meet requested a review from iam-vipin November 30, 2024 15:15

not-meet added 2 commits February 12, 2025 21:45

refactored quick create pr code removed unused params

c4ec6cc

added a quick create command exampe and tweaked utility logic

d8ce982

Merge branch 'RocketChat:main' into quickcreatereplies

9bf47bb

iam-vipin requested changes Feb 13, 2025

View reviewed changes

Merge branch 'RocketChat:main' into quickcreatereplies

3a5355d

iam-vipin requested changes Feb 21, 2025

View reviewed changes

not-meet changed the title ~~added a feature of quick create from the input box itself..~~ preview of reply in create modal Feb 21, 2025

not-meet changed the title ~~preview of reply in create modal~~ pre-filled quick create modal Feb 21, 2025

added final changes

bf658de

not-meet force-pushed the quickcreatereplies branch from 3f46624 to bf658de Compare February 22, 2025 20:40

removed spaces and unused imports

69818f2

iam-vipin requested changes Feb 23, 2025

View reviewed changes

not-meet changed the title ~~pre-filled quick create modal~~ [FEAT] : Added dynamic initial values in create modal Feb 23, 2025

not-meet added 2 commits February 24, 2025 04:26

completed requested changes

a275aea

removed spaces

aed5898

not-meet requested a review from iam-vipin February 23, 2025 23:15

Merge branch 'RocketChat:main' into quickcreatereplies

8a4b62a

iam-vipin requested changes Feb 25, 2025

View reviewed changes

renamed the args changes made as requested

1c9b802

not-meet requested a review from iam-vipin February 26, 2025 20:48

iam-vipin requested changes Feb 26, 2025

View reviewed changes

not-meet and others added 2 commits February 27, 2025 05:38

Merge branch 'RocketChat:main' into quickcreatereplies

30f37ab

made changes in readme file

b4e19a8

iam-vipin requested changes Feb 27, 2025

View reviewed changes

not-meet added 3 commits February 28, 2025 04:21

changes in readme

a42ce1c

changes in readme

f28fd6e

changes in readme

ca43cde

changes in readme

8f85896

not-meet requested a review from iam-vipin February 28, 2025 21:43

tweaked readme

22cd3c6

iam-vipin requested changes Mar 19, 2025

View reviewed changes

		`/quick create "<name>" <message>`: "if your name has multiple words with space, use double quotes" and write everything else as a body!

		Example: `/quick create "schedule meeting" let's have a quick meet in an hour!`

Conversation

not-meet commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue(s)

Acceptance Criteria fulfillment

Proposed changes (including videos or screenshots)

Demo

Uh oh!

CLAassistant commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iam-vipin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iam-vipin left a comment

Choose a reason for hiding this comment

Uh oh!

not-meet commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iam-vipin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iam-vipin commented Nov 23, 2024

Uh oh!

not-meet commented Nov 30, 2024

Uh oh!

iam-vipin commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

not-meet commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

not-meet commented Feb 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

not-meet commented Nov 22, 2024 •

edited

Loading

CLAassistant commented Nov 22, 2024 •

edited

Loading

not-meet commented Nov 22, 2024 •

edited

Loading

iam-vipin commented Dec 16, 2024 •

edited

Loading

not-meet commented Dec 17, 2024 •

edited

Loading