Skip to content

Imbued Support Selection Improvements#9786

Draft
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/gem-select-improvements
Draft

Imbued Support Selection Improvements#9786
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/gem-select-improvements

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented Apr 20, 2026

Description of the problem being solved:

Draft for now. Fixing up the Imbued GemSelect to process only when the buffer matches a gem name rather than always running the code for the gem at index 1 in the search list for every single change to the buf. The imbued will only be added if you: 1) click the gem 2) type the name out entirely or 3) use the arrows to select one from the list. If you have an imbued and then backspace, we would now only run the cycle once to remove the imbued as it doesn't match anymore. Simple rule is one cycle per match/un-match, not one cycle per changeFunc call/buf change.

I would like to do this for the other GemSelects but the changeFunction and structure of those are not the same and it's proving difficult.

Steps taken to verify a working solution:

There are a couple different states to keep in mind:

  • No Imbued > Open Dropdown > Click/Arrow to any in the list > Verify on group hover the correct gem is imbued
  • No Imbued > Open Dropdown > Type whatever that matches a support > Verify on group hover no gems are imbued unless the buffer matches a full gem name
  • Imbued > Dropdown > Backspace against the name, verify on first backspace the gem is removed as an imbued on hover > Verify clicking off the dropdown with an incomplete/non-matching name that the imbued select is cleared out.
  • Double check the clear button as I did a slight refactor of the function to reuse it elsewhere

Link to a build that showcases this PR:

eNqtXN132rgSf97-FT68N3yGkD2ke8gHTc5JGi6k7b1PPcIWoK1ssZJMwv71VyPZxoCNZew-tGDmNzMazYyk0bjDvz586mwwF4QFN432Ravh4MBlHgmWN43vb-PPg8ZfXz4NJ0iuXhe3IaHwy5dPfwz1Z8dHJJgx9zeWXzkL14pDw9kQ_P7CPHzTeHqZvE7fGs4cBR6RN41vLMANh-INpprSpUiIb8hXpDNXKdBwkHBx4N3tnhvIGgVyhVnwgv5m_Cvzjp6TYO-5u0IcuRLzZ5A1CiUzCkkeql8l4kssf8SD7v5qNdSI_hhOKNpiPpNIOkL9ddMYKcOgJX4kUo0K0VBx6Pc6F53WZaN5EnEbciHvka8-2iJna4y9hLiTRzbh-GGxwK4kG3zHibxbocBNCcnDlaV9Cakka0owT-jbF7nKPx4xb7daecRvTCJ6P5ntaDuD3kWvfZqe7eYgl_NPIle3VNmxBHfAPC0DInFJ0IQRwYIzxpGG5A7lLqRURZoV7RQLzDdIkn118nkzf06CUlYacYxeF8bzpsgjoXjBkmOR4LsX13nYFxSgOyZ289dpnSKdYK5ygNxDFAFm2GUqbaQhPRsh2dBc5DNZYHvKUgOJAGW1OW8cDzNbutKMz1NoqhKlHeWMhdSSUnILj5vif9KE3as8wnv8YcHuKZB2QtOE7cvLfKkbJvXKWDRcnV0eHiepALjoXrWuW4Pe4GpwlTuuyWoriIvoC_ogfuirTP6GfuOdwP4J_1uuZKCSVB4035hjwnEeqnedn7eoV16WWpiYyIUNTkWXhRHUsu3-CbRPgWsXst8DrvN1arXvnwRMVSDBtmJOsSViJyIKR5tl2Yha4iCSt7UbzjPG7uqr2gZOkcR2CTuhujxtVqC1MisQZpi127EDHBqp3zuFy7HR6fWvpJUeAsyX29mKYOqVo44Vu0NrixQJVk6jray9L66Uw6ShJU3yE3HPbiEpq9MGiXSGbfdPm8uQ2_klVptRBfDwwe64lb-9Z3_D5p6Wg424z0JuOeGG2GoA8eJgjjJT7IWu3WqUnFFuqTod2g4jQSk9KS0FHUmJ3N_3zFtaG00LKYXY128WrtcqhYA32DKAdU_t1klq__K5fV1M_apc2SqiYYk8FNC3oLYWkCz69lIOIPZjgYW7xGB25NYikgl9UcnCV2uAPoW_sF2myT0RjdUBzeq0pQktT30T9q40X0F9QpSjVhuc3bqXqwrHwb9ba_575FYCHgIv5BAK1jIOEVli3oivEqkQ90gix4t2xD8QJyiQbV1IOnjY0Q8FRtxdPSt_uGmkv40RpXOVLPRTXbsaEyoxv1e_gSaxtsOmrnHBp9lvQqlQYhYopPIr9p9NDStg3E-2zorbir0_4yVyt4pE3DQWiAqVFZDJGcBjhqXRTVFC_mAcuL1t11iRj56fQSP9SNxulcfEFaud4P-EiBK5BR33Scewpu6f7bXxYrEO8UAyPIse6uLdaKebVowELg09tZuN_DsZxAHxHaKu0AiK5mAKqBvCFtWLdRaUwbKN0ZoFDnD25yH2okGriac64BB1xswNhVHsj6Eaj_NPeowg7EkxHVPk41nIoaJ2IGmJfaB4wRJ5ykWaT1IZpQmWaWpd1SeN_rki6xj8lbI5ou2YRVSTVEc2JwA5ap2MRDp7Mg2sE8NcFgZmQjfG8w40bRpzGzVOmj4gNMv4-nG26fVPOcYvMuYPhOiTvw65-uV1AevMOUYFLrs1aqTi-Mi6kfNkmhfgTqyFwxZOWg8bQ2eM4sjg0UcVADqiTSDDRz0eJxTY1CmMn-rw3ItaINsLWpW17olaNlRudCFoE3sPI9JTPPdiUMWHQ6Qxc2SYJF46zuwdrZ3RfCuEspIpsTv9hgZM5t-nz2rSmxaM2oc8Ls_hkaVMpy5G7RKMbhmToopZMhlc1mDXdnkenUqWwFTWoEO7Lkc7Gky34mDK4FXKFb_P8chOZY_MG34ZZVSy22BRRYtsDp1SgeFtHXM0rKKImYlu1Yg8O7mcgSsBGfkhxbIE4BFTvxQgdqfzZq60x5SdpxL0U3XiK2VcDeiUBZRNM5WDqleGA0eL2sKwW9rvaoiqTqXhZxqwW1eavqzHrpeV7dqrwa79egZTxxRfVs3evaoMqu4d-pWdtF_XVqq2_XblNbVdV9z1KgdM9ZDr1rBl79UTcjWx6dc1PVWDp1N6gat6bqnj_NUpvUntlUbUoWcdjtsvrXm7csCd7Z6VU3H1ZFHbubhX0dF7dcV4lrcPm1EFyhTNOfLwTBe9f2K4gRGmpq3rXvBJlxFN4SpYhzKSqkuEv4LQn0Pnn_l3dwuSpvSJcH_Nw8UCWisbjpBc94w-jMcPd29PPx4iyAzrK0Nd-opKcVQ9gpIepWgtoOIYVcdEOBeG-qbxg-B3TX6PJSJUZHB7JEmL5Wlems-O-pjTT2UlTuA0dJrRwwfmUo0yoT9mpfsULdQxusAVNdxuZNnK9IOeZmVuPe-QkPoS_ZgLtHIWMQGarKE8-WtEC40bUeVMNtxsQMlUWBlFwj3IGrtkQVyDypz1-La1wDauG3LkbjN46B7RIrwhOgabvs8idESVYVXda1poVUOV4V_YRdsitCE6BictF0UMEkIWQPPzMacHikeEwgVO4cx-Y4F2dhU3CeSY4YvKJuY2tpDhq1xhHtMec1Ixwck8lMXhnKLMsJXu_yowE9BkjEX3OJ2GapoMu-41_hRkozRtZlIrZKFpjqHxpftpsKHKnIKoGFVgfkOVYYS4I6dg_BFZRpDo5DraMOLZZIpD8soMdedKDXpBb0p1NofNKhkc9SaxMF4iKit4dAecQn-XBC4iqzGBiKvGAQKvGoc3Ergy5JlZY3q4HTmGT7P3IEnHxElwTHUuPmm3OJuDaQo5G657VnLy_z1e6EtVqwUgIa7Ga8zUjk5tN_TbExV5zWQY3CvzlmV1bCU9wlMJqTQvs_KeMJpJKlF3tE2-NKTVGal9wWP2BrQEp6SR6xEjCu_mMFqN4WHDuD2zjIjHLgvXKPBibq_52_4y1mNSKKa6Sekeel5FJS3VdsLfpvgMm_EJcfiNqT0SsIan8Zeh2vmr4HHwB_wzQRyaTIyaGn7HggVZRm0U5kvUSKGVTJ44kkiKYdOqe5z2myQmFLl4xaiHeXTsxKDmfl_q7pza6cSvMOVC4bRzCOu28kHrpCM37g_b4XqtImHqSTkdXWMWdQiSHNE3ssT8DnpfdvjLIpnQB3kodHDdt1B1Ak6SGMXCkPFJzFa3dP9rgikyYrIdTKoRrXavSLuk6fQcF0k10dpo6SfvSuoYekSUsnclWjeCHRVRTk_codxukXXivXYM6LevB9cFmKi2EEOuWkVCdLtjypt6ttYv5VHgHWdMF8BKyYm62VUynKIgLeyqZTuu89wDXhvFHHszXbWBsJ5hukh5yIn4mbmMuyuNFFY-JciS0NeF3nApmN6aWcBmK3V2KSEGWnMzUuOpoewMsh8qRuoU-2yDvdvtiNLtcQmymSwcZo3S3-DjG8cYqobOv4zF_bndhv72P9P9qIuhM8mhXxIe_9c8zu3q08uYXtgcDwtJAhQdXKmKBWWn95G3gVG_qd1Gqtt3vcaBt7cUgmpxF7BufYzWQPji-EhIzLdRQQN0C5gHOlwOBt0uqA29hIhvR7t346FQrPs_XRoC-hGJ1Rh6kXdvtXcajgSL7N5y7wyiN-6jMjPa59eKltzv02fTPrqSci3-bDbf398v1kiu2AJ_qGXwwmV-c61AajSfdbn4MwhqjtSf2-VI_zFNmDGnoSlai8ghYPfDiRpiNKFgBT2XYKYvn4bNw_9s4P_KCrk3

Before screenshot:

beforeImbuedImprovements

After screenshot:

afterImbuedImprovements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant