fix: support Zotero 8 and stabilize citationKey handling#459
Open
Ascarshen wants to merge 1 commit intoPKM-er:masterfrom
Open
fix: support Zotero 8 and stabilize citationKey handling#459Ascarshen wants to merge 1 commit intoPKM-er:masterfrom
Ascarshen wants to merge 1 commit intoPKM-er:masterfrom
Conversation
Member
|
Thank you! I'll test this locally and get this merged with some feat port back |
Member
|
i would suggest separate Zotero plugin changes from this PR so I can get obsidian plugin PR merged sooner and have an working obsidian plugin first. I haven't develop for Zotero plugins for quite some time so i'll need some time to catch up with the Zotero updates from 6 to 8. |
Member
|
btw, i've include an update that remove the custom build for better-sqlite3 from zotlit, you should rebase your branch first in case of conflicts. |
ebda9f5 to
0b8099e
Compare
Author
|
Rebased onto latest This PR now only keeps the Obsidian-side changes plus the shared citekey/backend pieces needed by the Obsidian plugin: The Zotero plugin changes have been moved to a separate branch/PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores compatibility with Zotero 8 and fixes several related regressions in both the Zotero and Obsidian sides of
obsidian-zotlit.It focuses on three areas:
citationKey/ Better BibTeX fallback handlingChanges
added Zotero 8-compatible bootstrap fallback via
Services.sys.mjsupdated item menu registration for Zotero 8
added MenuManager-based menu support and virtual menu adapters
updated reader menu/event hooks to support newer reader internals
hardened annotation update logic for changed reader iframe/window fields
fixed citekey backend selection in the db worker
fixed legacy BBT v0 search DB attachment alias
added fallback to Zotero native
citationKeywhen BBT DBs are unavailablefixed load status reporting for native citationKey fallback
updated Zotero addon compatibility metadata to
strict_max_version: 8.*fixed Obsidian-side async
effect()callback issuesremoved the broken direct dependency on
@preact/signals-corefixed plugin context typing around
use.plugin(this)improved template preview and citekey-click behavior for deferred markdown leaves
fixed JSON request parsing in the local Obsidian server
fixed citation insertion so stale results no longer render
[@undefined]updated default citation templates to skip missing citekeys instead of rendering
undefinedValidation
app/zoterotypecheck passedapp/obsidiantypecheck passedapp/obsidianproduction build passed[@undefined]Notes
This PR contains source-level compatibility fixes only.
I intentionally left local environment-only changes, temporary test fixtures, and unrelated workspace noise out of this branch.