Conversation
shinenelson
left a comment
There was a problem hiding this comment.
@mattdzugan, thank you for adding the icon for Observable to Fork Awesome. It looks good 👌
However, in order for these changes to be merged in, can you please remove the generated font files from fonts and also src/icons/.fontcustom-manifest.json?
The duplication of package.json in src/icons is not required as well. Also, please resolve the merge conflict in src/icons/icons.yml by accepting both changes.
|
Will do thank you @shinenelson !! |
That would be great. It would be appreciated if you could create a separate pull request for it. We try and keep pull requests concise with what it does. The reasoning behind that is because we follow a squash merge strategy and it would make sense to have only one item per pull request. |
|
I am sorry about the locking. It was an accidental tap on mobile 😅 |
Proposing a new icon for Observable
had to create a second PR cuz i broke travis the first time 😬