[esphome] Modernise board spec, web server v3, remove legacy options#46
[esphome] Modernise board spec, web server v3, remove legacy options#46TrevorSchirmer merged 4 commits intobetafrom
Conversation
…ions - Remove redundant esp32 board string (variant + flash_size already present) - Add web_server version: 3 to Core.yaml and R_PRO-1_W.yaml - Remove platformio_options board_build.flash_mode from both device YAMLs - Remove legacy BLE wifi on_connect/on_disconnect hooks from R_PRO-1_W.yaml
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
esp32: board: esp32-s3-devkitc-1string from Core.yaml (variant: esp32s3+flash_size: 8MBalready present and sufficient)version: 3toweb_server:in Core.yaml (used by ETH variant) and R_PRO-1_W.yaml (WiFi variant overrides)platformio_options: board_build.flash_mode: diofrom R_PRO-1_W.yaml and R_PRO-1_ETH.yaml (not needed when using variant/flash_size spec)on_connect: ble.disable/on_disconnect: ble.enable) from R_PRO-1_W.yamlTest plan
esphome configvalidates cleanly for R_PRO-1_W.yaml and R_PRO-1_ETH.yamlType of change
Checklist