Skip to content

[esphome] Modernise board spec, web server v3, remove legacy options#46

Merged
TrevorSchirmer merged 4 commits intobetafrom
esphome-modernisation
Feb 27, 2026
Merged

[esphome] Modernise board spec, web server v3, remove legacy options#46
TrevorSchirmer merged 4 commits intobetafrom
esphome-modernisation

Conversation

@bharvey88
Copy link
Copy Markdown
Contributor

Summary

  • Remove redundant esp32: board: esp32-s3-devkitc-1 string from Core.yaml (variant: esp32s3 + flash_size: 8MB already present and sufficient)
  • Add version: 3 to web_server: in Core.yaml (used by ETH variant) and R_PRO-1_W.yaml (WiFi variant overrides)
  • Remove platformio_options: board_build.flash_mode: dio from R_PRO-1_W.yaml and R_PRO-1_ETH.yaml (not needed when using variant/flash_size spec)
  • Remove legacy BLE wifi hooks (on_connect: ble.disable / on_disconnect: ble.enable) from R_PRO-1_W.yaml

Test plan

  • esphome config validates cleanly for R_PRO-1_W.yaml and R_PRO-1_ETH.yaml
  • OTA flash succeeds on a WiFi device
  • OTA flash succeeds on an Ethernet device
  • Web server UI loads at device IP on both variants

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

…ions

- Remove redundant esp32 board string (variant + flash_size already present)
- Add web_server version: 3 to Core.yaml and R_PRO-1_W.yaml
- Remove platformio_options board_build.flash_mode from both device YAMLs
- Remove legacy BLE wifi on_connect/on_disconnect hooks from R_PRO-1_W.yaml
@github-actions github-actions bot added the new-feature New feature label Feb 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 25, 2026

Warning

Rate limit exceeded

@bharvey88 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between eec54f5 and 07d495c.

📒 Files selected for processing (3)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/R_PRO-1_ETH.yaml
  • Integrations/ESPHome/R_PRO-1_W.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch esphome-modernisation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TrevorSchirmer TrevorSchirmer merged commit 6fa5cce into beta Feb 27, 2026
9 checks passed
@TrevorSchirmer TrevorSchirmer deleted the esphome-modernisation branch February 27, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants