use strdup instead of manual malloc+memcpy

[ret2libc]

In multiple places strings are copied from one place to another, but instead of using strdup or the str* functions, the project seems to prefer malloc+memcpy, which IMHO results in less readable more error-prone code.

Examples of this:

libcomps/libcomps/src/comps_objmradix.c

Line 46 in 2ed0fe5

memcpy(rtd->key, key, sizeof(char)*keylen);

libcomps/libcomps/src/comps_doc.c

Line 263 in 2ed0fe5

memcpy(ret, xmlstr, sizeof(char)*(strlen(xmlstr)+1));

libcomps/libcomps/src/comps_elem.c

Line 890 in 2ed0fe5

memcpy(attr->name, name, sizeof(char)*(strlen(name)+1));

libcomps/libcomps/src/comps_elem.c

Line 891 in 2ed0fe5

memcpy(attr->val, val, sizeof(char)*(strlen(val)+1));

.. and many others.

[dcantrell]

I agree. The malloc+memcpy style is harder to read. Patch coming soon.

[j-mracek]

I agree that it looks not nice but if there is not an issue, I would prefer to keep it like it is. Please look at the patch frequency in the project and you will discover that the project has not much contribution. In future it will be even not used by DNF5.