Add send-input command with delayed enter and optional activation#20106
Closed
laffo16 wants to merge 4 commits intomicrosoft:mainfrom
Closed
Add send-input command with delayed enter and optional activation#20106laffo16 wants to merge 4 commits intomicrosoft:mainfrom
laffo16 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
I'm sorry, but we will not be accepting any work that adds a remote input injection vulnerability to Windows Terminal. Adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
wt send-inputcommand for sending text to the active pane.Included in this change:
send-input <input...>--enter--enter-delay-ms <ms>--activateBehavior notes:
send-inputtargeting an existing window stays in the background by defaultsend-input --activateopts back into the normal summon/foreground behaviorfocus-tab ; send-inputstay background by defaultnew-tab ; send-inputandsplit-pane ; send-inputpreserve existing activation behaviorExamples
Implementation Notes
SendInputaction pathnew-tabfor automation-style send/focus flowsValidation
Built successfully:
SettingsModel.UnitTests.vcxprojTerminalApp.LocalTests.vcxprojFocused tests passed:
SettingsModelUnitTests::KeyBindingsTests::HashDeduplicationSettingsModelUnitTests::KeyBindingsTests::DefaultArgSemanticDeduplicationSettingsModelUnitTests::KeyBindingsTests::SendInputZeroDelayDeduplicationSettingsModelUnitTests::KeyBindingsTests::SendInputDelayedEnterStaysDistinctTerminalAppLocalTests::CommandlineTest::ParseSendInputArgsManual smoke also passed against a side-by-side patched Terminal Dev package:
send-input--activatefocus-tab ; send-input--enter --enter-delay-ms