-
Notifications
You must be signed in to change notification settings - Fork 9.2k
"Incomplete" color schemes are rejected as if they don't exist (possibly only if in fragment) #11457
Copy link
Copy link
Open
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-2A description (P2)A description (P2)Product-TerminalThe new Windows Terminal.The new Windows Terminal.good first issueThis is a fix that might be easier for someone to do as a first contributionThis is a fix that might be easier for someone to do as a first contribution
Milestone
Metadata
Metadata
Assignees
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-2A description (P2)A description (P2)Product-TerminalThe new Windows Terminal.The new Windows Terminal.good first issueThis is a fix that might be easier for someone to do as a first contributionThis is a fix that might be easier for someone to do as a first contribution
Windows Terminal version (or Windows build number)
1.11.2421.0, 1.10.2383.0
Other Software
No response
Steps to reproduce
Use a color scheme that is "incomplete" in a fragment, use the scheme name's in your default profile.
Example:
Drop in
%LOCALAPPDATA\Microsoft\Windows Terminal\Fragments\Test\Test.json, and changesettings.json'sdefaults: colorSchemetoTest. Launch WT, get greatly misleading warning.Notice the use of #11456 here. Else, everything seems to be listed as per the documentation on schemes.
Change "Magenta" to "Purple" on both lines, and watch the fragment suddenly be discoverable and work.
Also note: the colors in this scheme are garbage on purpose, if they're ugly, its working.
Expected Behavior
Either working behavior (with the missing colors replaced with Campbell's) and/or a warning specifically telling me what is wrong with the scheme. At no point should WT tell the user that the scheme doesn't exist without any other warnings that specifically state the scheme was found, but is incomplete.
Actual Behavior
On launch with incomplete scheme in fragment, but specified in
settings.jsonNotice the lack of saying the color scheme exists, but misses elements; it just claims it never existed ever, which leads to a day long wild goose chase.