Skip to content

Commit 5641289

Browse files
Ben HillisCopilot
andcommitted
Fix _Guarded_by_ annotations for m_utilityVm and m_runningInstances
Update SAL annotations from m_instanceLock to m_callbackLock to match actual locking: mutations are guarded by m_instanceLock, but callback reads are guarded by m_callbackLock (shared_mutex). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 68cdc8b commit 5641289

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/windows/service/exe/LxssUserSession.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -804,8 +804,9 @@ class LxssUserSessionImpl
804804

805805
/// <summary>
806806
/// Contains the currently running utility VM's.
807+
/// Mutations guarded by m_instanceLock; callback reads guarded by m_callbackLock.
807808
/// </summary>
808-
_Guarded_by_(m_instanceLock) std::map<GUID, std::shared_ptr<LxssRunningInstance>, wsl::windows::common::helpers::GuidLess> m_runningInstances;
809+
_Guarded_by_(m_callbackLock) std::map<GUID, std::shared_ptr<LxssRunningInstance>, wsl::windows::common::helpers::GuidLess> m_runningInstances;
809810

810811
/// <summary>
811812
/// Contains a list of instances that have been terminated.
@@ -821,8 +822,8 @@ class LxssUserSessionImpl
821822
/// <summary>
822823
/// The running utility vm for WSL2 distributions.
823824
/// Mutations guarded by m_instanceLock; callback reads guarded by m_callbackLock.
824-
///
825-
_Guarded_by_(m_instanceLock) std::unique_ptr<WslCoreVm> m_utilityVm;
825+
/// </summary>
826+
_Guarded_by_(m_callbackLock) std::unique_ptr<WslCoreVm> m_utilityVm;
826827

827828
/// <summary>
828829
/// Reader-writer lock protecting m_utilityVm and m_runningInstances for

0 commit comments

Comments
 (0)