-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy path.coderabbit.yaml
More file actions
49 lines (45 loc) · 1.57 KB
/
.coderabbit.yaml
File metadata and controls
49 lines (45 loc) · 1.57 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
language: "en"
early_access: true
reviews:
request_changes_workflow: true
high_level_summary: true
poem: false
review_status: true
collapse_walkthrough: false
sequence_diagrams: true
profile: "chill"
path_filters:
- "!**/*.md"
- "!**/*.yaml"
- "!**/*.yml"
- "!**/*.json"
- "!**/*.toml"
- "!**/*.xml"
- "!.cursor/**"
- "!.git/**"
- "!.claude/**"
- "!.vscode/**"
- "!.agents/**"
- "!**/fixtures/**"
- "!test/testdata/**"
path_instructions:
- path: "**/*_test.go"
instructions: |-
# Test Review Requirements
## Critical Patterns to ENFORCE:
- MUST use t.Run("Should...") pattern for ALL test cases
- MUST test meaningful business logic, not trivial operations
- MUST have specific error assertions (ErrorContains, ErrorAs)
- MUST avoid redundant validation tests across packages
## Anti-Patterns to REJECT:
- Constructor tests that only check != nil
- Getter/setter tests without business logic
- Tests with 90% mock setup, 10% actual testing
- Weak assertions like assert.Error(t, err) without message validation
- Tests that verify Go standard library functionality
- Duplicate test scenarios across packages
## Must Check:
- Focus on critical paths: parsing, graph normalization, metrics, vault rendering
- Verify tests can fail when business logic changes
- Check for shared test utilities usage to avoid duplication
- Ensure tests verify behavior outcomes, not just function calls